Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getMeasurements does not work with background measurements #101

Open
atsanda opened this issue Sep 18, 2024 · 2 comments · May be fixed by #107
Open

getMeasurements does not work with background measurements #101

atsanda opened this issue Sep 18, 2024 · 2 comments · May be fixed by #107
Labels

Comments

@atsanda
Copy link

atsanda commented Sep 18, 2024

I am trying to load an mdf which contains background measurements only using

c = getMeasurements(c_mdf, false; tfCorrection=false, spectralLeakageCorrection=false)

I get the following error:

ERROR: BoundsError: attempt to access 3300000-element Vector{Bool} at index [3300001]
Stacktrace:
 [1] getindex
   @ ./essentials.jl:13 [inlined]
 [2] measBGFrameIdx(f::MDFFileV2{Array{Int16, 4}})
   @ MPIFiles ~/.julia/packages/MPIFiles/Ag3SE/src/Derived.jl:52
 [3] top-level scope
   @ /.../Main.jl:5

I think it is caused by measBGFrameIdx

@atsanda atsanda added the bug label Sep 18, 2024
@atsanda
Copy link
Author

atsanda commented Sep 18, 2024

The problem appears in newer versions because, when downgraded to MPIFiles v0.14.1, it is no longer reproducible

@jusack jusack linked a pull request Oct 23, 2024 that will close this issue
@jusack
Copy link
Contributor

jusack commented Oct 23, 2024

While I was changing stuff in Derived.jl I removed the manual implementation of measBGFrameIdx and just used Julia's findall. If you could check if this fixes your issue that would be great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants