Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New feature: support WalletConnect #176

Merged
merged 16 commits into from
Jul 14, 2023
Merged

New feature: support WalletConnect #176

merged 16 commits into from
Jul 14, 2023

Conversation

@poor-defined
Copy link
Contributor Author

poor-defined commented May 31, 2023

@Kirl70 I have updated the Send Tx section of the Axure link, could you pls design it before next monday?
image

@Kirl70
Copy link

Kirl70 commented Jun 2, 2023

@Kirl70 I have updated the Send Tx section of the Axure link, could you pls design it before next monday? image

Design Draft ( 3-1 ~ 3-7 ):
https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?type=design&node-id=16536%3A38593&t=QsMaQAtJrw34nlCb-1
image


- Click the arrow next to the address. The Data and Witness will display(elaborately speaking, these details will move upwards)
![picture 4](pic/70d8140d96601991d8aa2632fc65d0c2a1eccef17ed02505fe50b9adade86115.png)
- In the UI demo, click this arrow, users can view all the receiving addresses, then view the data and witness the one you want by click the arrow next to the address on list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The detail should be described by text clearly and abstractly.
click this arrow is concrete, check more addresses is abstract

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is the abbreviation of address list shown should be described.

In the screenshot, To address: ckt...s49 / ckt...82 / ... is meaning less.
What if show the addresses in various format based on the count:

  1. only 1 address: display the full address
  2. more than 1 address: show the count of addresses and check address list in another view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants