Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the amount difference of an account within wallet-connect #212

Open
Tracked by #176
poor-defined opened this issue Jul 6, 2023 · 2 comments
Open
Tracked by #176
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@poor-defined
Copy link
Contributor

The current Amount field in the wallet-connect General Component is the amount of raw transaction data rather than the real amount the account will pay due to the UTXO model.

For example, Account A which have 2 address a_1 and a_2 is supposed to sign a transaction, that is address a_1 put 100 CKB as input, and address a_2 get 10CKB change, and b_1, the dapp's address, get 90 CKB.
The Amount field will show 100 CKB on the transaction page, however, the user actually only pays 90 CKB. So putting the actual value of 90 on the transaction page is worthwhile.
image

@poor-defined
Copy link
Contributor Author

poor-defined commented Jul 11, 2023

这个是UX方面的协议

image The account model is the recommended implementation model for this protocol. When a dapp is connected to a CKB wallet that implements the account model, the displayed token values on the page represent the net value relative to the account.

@Keith-CY Keith-CY added this to Neuron Jul 12, 2023
@poor-defined
Copy link
Contributor Author

需要注意的是:To Address (可改名为Recipient) ,同时需要去掉list中属于用户账户的找零地址。

@Danie0918 Danie0918 added the documentation Improvements or additions to documentation label Jul 17, 2023
@Danie0918 Danie0918 moved this to 📫Hold On in Neuron Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: 📫Hold On
Development

No branches or pull requests

2 participants