Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add search result tokens page #816

Merged
merged 11 commits into from
Jan 6, 2023
Merged

feat: add search result tokens page #816

merged 11 commits into from
Jan 6, 2023

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Dec 26, 2022

resolves Magickbase/godwoken_explorer#1237, resolves Magickbase/godwoken_explorer#1232

  • replace search api to graphql
  • add a new search result page for tokens:
search-result.mov

@vercel
Copy link

vercel bot commented Dec 26, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
godwoken-explorer-ui ✅ Ready (Inspect) Visit Preview Jan 5, 2023 at 10:47AM (UTC)

@qiweiii
Copy link
Contributor Author

qiweiii commented Dec 26, 2022

may need to wait for backend PR merge so search number/id/addr/hash works: Magickbase/godwoken_explorer#1234

@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2022

Codecov Report

Merging #816 (21ad70e) into develop (e670e7f) will decrease coverage by 13.48%.
The diff coverage is 62.62%.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop     #816       +/-   ##
============================================
- Coverage    79.00%   65.51%   -13.49%     
============================================
  Files           26       18        -8     
  Lines          481     1128      +647     
  Branches       116      665      +549     
============================================
+ Hits           380      739      +359     
- Misses          97      340      +243     
- Partials         4       49       +45     
Impacted Files Coverage Δ
pages/404.tsx 5.00% <0.00%> (-95.00%) ⬇️
pages/tx/[hash].tsx 73.25% <ø> (+12.64%) ⬆️
pages/txs/index.tsx 87.80% <ø> (ø)
pages/search-result-tokens/index.tsx 8.00% <8.00%> (ø)
pages/contracts.tsx 10.52% <10.52%> (ø)
pages/token/[id].tsx 43.30% <43.30%> (ø)
pages/nft-collection/[address].tsx 53.57% <53.57%> (ø)
pages/account/[id].tsx 56.37% <56.08%> (-21.89%) ⬇️
pages/multi-token-collection/[address].tsx 56.36% <56.36%> (ø)
pages/blocks.tsx 75.00% <75.00%> (ø)
... and 20 more

@Keith-CY
Copy link
Member

Seems that searching is not smart/fuzzy enough

Results of searching Yokai
PR: https://godwoken-explorer-ui-git-feat-search-token-magickbase.vercel.app/search-result-tokens?search=Yokai
Online: https://v1.testnet.gwscan.com/tokens/native?name=Yokai&search=Yokai

@FrederLu
Copy link
Contributor

FrederLu commented Jan 3, 2023

@qiweiii
Search for address information that may not exist, and the returned page data display is abnormal. The interface prompts 500.
https://godwoken-explorer-imuqrb1mm-magickbase.vercel.app/account/0x8b1bf0f8da7d75c262a5498f1158368e513ec293?search=0x8b1bf0f8da7d75c262a5498f1158368e513ec293
image

pages/search-result-tokens/index.tsx Outdated Show resolved Hide resolved
pages/search-result-tokens/index.tsx Outdated Show resolved Hide resolved
@qiweiii qiweiii merged commit a13bc2b into develop Jan 6, 2023
@qiweiii qiweiii deleted the feat/search-token branch January 6, 2023 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
5 participants