Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a page for filtered ERC20/721/1155 #1232

Closed
Keith-CY opened this issue Dec 21, 2022 · 1 comment · Fixed by Magickbase/godwoken-explorer-ui#816
Closed

Add a page for filtered ERC20/721/1155 #1232

Keith-CY opened this issue Dec 21, 2022 · 1 comment · Fixed by Magickbase/godwoken-explorer-ui#816
Assignees
@qiweiii
Labels
enhancement New feature or request
Milestone
2022/12/21 - 2022...

Comments

@Keith-CY
Copy link
Member

This page comes from Magickbase/godwoken-explorer-ui#684 (comment)

There could be several records hit if a token name is searched, and they should be listed together instead of navigating to one of them, so a new page for the filtered tokens is required

API: #1161
UI Design: Magickbase/visual-style-guide#13
@Keith-CY Keith-CY added the enhancement New feature or request label Dec 21, 2022
@qiweiii qiweiii moved this from Todo to In Progress in Nervos Wallet/Explorer Dec 23, 2022
@qiweiii qiweiii mentioned this issue Dec 26, 2022
Merged
@Keith-CY
Copy link
Member Author

PR: Magickbase/godwoken-explorer-ui#816

@Keith-CY Keith-CY added this to the 2022/12/21 - 2022-12/28 milestone Dec 28, 2022
@qiweiii qiweiii moved this from In Progress to QA in Nervos Wallet/Explorer Jan 3, 2023
@github-project-automation github-project-automation bot moved this from QA to Production in Nervos Wallet/Explorer Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiweiii qiweiii

Labels
enhancement New feature or request
Projects
No open projects
Nervos Wallet/Explorer
Archived in project
Milestone
2022/12/21 - 2022-12/28
Development

Successfully merging a pull request may close this issue.

feat: add search result tokens page Magickbase/godwoken-explorer-ui
2 participants
@Keith-CY @qiweiii