Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(btc): add op return #347

Merged
merged 20 commits into from
Jun 11, 2024
Merged

feat(btc): add op return #347

merged 20 commits into from
Jun 11, 2024

Conversation

Daryl-L
Copy link

@Daryl-L Daryl-L commented May 28, 2024

@vercel Vercel
Copy link

vercel bot commented May 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ckb-explorer-frontend-in-magickbase-repo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 7, 2024 9:30am

@Daryl-L Daryl-L mentioned this pull request May 28, 2024
Closed
@FrederLu
Copy link

https://mempool.space/testnet/tx/7bc10f67d40b13f4eec1b6b3f041e945696443b450b4fbbc55d4c044b6a681a6
image

https://ckb-explorer-frontend-in-magickbase-repo-oox4vjxsu-magickbase.vercel.app/transaction/0x1dc8527ffccb9ed8330c299c4018552508667ac9d5f29eeae802b4f9eace7c5a
image

Is OP RETURN displayed here or does it need to display the complete OP_RETURN Yn :;$< C "Dѐ information like on https://mempool.space/? cc @Sven-TBD

@poor-defined
Copy link

Yes we want some more info here , on the proposal, it looks like this
image
cc @Kirl70

@Kirl70
Copy link

Kirl70 commented May 29, 2024

Design Draft:
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=35067%3A20864&t=Rcem2oAZ16TjqGty-1
image

@Daryl-L
Copy link
Author

Daryl-L commented May 29, 2024

Yes we want some more info here , on the proposal, it looks like this image cc @Kirl70

It's commitment, which is displayed over head. and the decode of this is meaningless

devchenyan and others added 4 commits May 29, 2024 15:51
@devchenyan @Keith-CY
feat: Add list view for XUDT and RGB++ List (nervosnetwork#1619)
d9c1050 
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
@Keith-CY
Merge pull request nervosnetwork#1630 from nervosnetwork/develop
d0a0315 
Merge develop into testnet
@Keith-CY @devchenyan
Merge pull request nervosnetwork#1631 from nervosnetwork/testnet
bbb6d28 
Co-authored-by: devchenyan <sgt39007@163.com>
Co-authored-by: Chen Yu <keithwhisper@gmail.com>
@Keith-CY
Merge pull request nervosnetwork#1629 from nervosnetwork/master
5ea8999
@poor-defined
Copy link

Yes we want some more info here , on the proposal, it looks like this image cc @Kirl70

It's commitment, which is displayed over head. and the decode of this is meaningless

We can add it here, coz it's related with the RGB++ tx. And I guess this message is already included in the envelop icon.
@Daryl-L Could you move it to this new place? We can extend the time of this issue, if you could add this feature here.
image

@Daryl-L
Copy link
Author

Daryl-L commented May 31, 2024

Yes we want some more info here , on the proposal, it looks like this image cc @Kirl70

It's commitment, which is displayed over head. and the decode of this is meaningless

We can add it here, coz it's related with the RGB++ tx. And I guess this message is already included in the envelop icon. @Daryl-L Could you move it to this new place? We can extend the time of this issue, if you could add this feature here. image

Do you mean move the commitment here, and no longer display on the right of the btc tx id?

Keith-CY added 4 commits May 31, 2024 17:12
@Keith-CY
feat: optimize address ranking chart
3eb765e 
1. move activities section to the top of charts
2. move address ranking to the head of actitivies section
3. move charts link next to nervos dao in the header
4. rename address ranking to top 50 holders
5. add top 50 holders list on the top 50 holders chart page
@Keith-CY
Merge pull request nervosnetwork#1632 from nervosnetwork/master
2a184b6
@Keith-CY
feat: allow users to select field of script on scripts page
0af84e5
@Keith-CY
fix: fix display of sudt in lite transaction
bb18f04
@Keith-CY
Copy link
Member

Keith-CY commented Jun 3, 2024

Yes we want some more info here , on the proposal, it looks like this image cc @Kirl70

It's commitment, which is displayed over head. and the decode of this is meaningless

We can add it here, coz it's related with the RGB++ tx. And I guess this message is already included in the envelop icon. @Daryl-L Could you move it to this new place? We can extend the time of this issue, if you could add this feature here. image

Do you mean move the commitment here, and no longer display on the right of the btc tx id?

@Sven-TBD please check

zmcNotafraid and others added 2 commits June 5, 2024 04:22
@zmcNotafraid
feat: show ckb hodl wave chart (#254)
63bacde 
* feat: show ckb hodl wave chart

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>

* fix: typo

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>

* feat: only mainnet show ckb_hodl_wave chart

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>

* style: change chart colors

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>

---------

Signed-off-by: Miles Zhang <mingchang555@hotmail.com>
@Keith-CY
fix: fix typo in rgb++ chart
8e99a6c
@poor-defined
Copy link

commitment

Yes, move this commitment info to the OP_Return hover.
@Kirl70 Could you please provide a UI indication for this?
image

@poor-defined
Copy link

UI reference：
https://www.figma.com/design/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=35067-20864&t=ys0Ii44ndvEZOux9-4

@Daryl-L

@Keith-CY Keith-CY merged commit 7f7e0bb into develop Jun 11, 2024
8 checks passed
@Keith-CY Keith-CY deleted the feature/add-op-return branch June 11, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keith-CY Keith-CY Keith-CY approved these changes

@FrederLu FrederLu FrederLu approved these changes

@PainterPuppets PainterPuppets Awaiting requested review from PainterPuppets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Daryl-L @FrederLu @poor-defined @Kirl70 @Keith-CY @devchenyan @zmcNotafraid @PainterPuppets