Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-ical update to minimum version to 0.15.0 #2824

Closed
kuosman opened this issue Mar 21, 2022 · 3 comments
Closed

node-ical update to minimum version to 0.15.0 #2824

kuosman opened this issue Mar 21, 2022 · 3 comments

Comments

@kuosman
Copy link

kuosman commented Mar 21, 2022

Hi,
Calendar module uses node-ical. There is one issue on Google calendar and Microsoft ism.
See more: jens-maus/node-ical#169

They have fixed this to node-ical 0.15.0 version jens-maus/node-ical#170 & https://github.com/jens-maus/node-ical/commits/0.15.0

Maybe MM can update this also so more ics calendars are working again :)

@rejas
Copy link
Collaborator

rejas commented Mar 25, 2022

IIRC there was already an attempt to upgrade node-ical to a newer version which failed due to missing luxon package: #2716

Doesnt seem fixed with 0.15.0 as far as I can see. Or is that "--no-optional" install switch not relevant for us anymore @khassel ?

@khassel
Copy link
Collaborator

khassel commented Mar 26, 2022

This is related to #2718

I need --no-optional when building docker images for server only (without electron).

Will tests this when I'm back home next week.

khassel added a commit to khassel/MagicMirror that referenced this issue Mar 28, 2022
@khassel
Copy link
Collaborator

khassel commented Apr 1, 2022

this is fixed in the new v2.19.0 release and should be closed @kuosman @MichMich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants