Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

problems with node-ical and rrule #2718

Closed
khassel opened this issue Nov 29, 2021 · 0 comments
Closed

problems with node-ical and rrule #2718

khassel opened this issue Nov 29, 2021 · 0 comments

Comments

@khassel
Copy link
Collaborator

khassel commented Nov 29, 2021

With an update of node-ical from 0.13.0 to 0.14.1 the installation of mm was broken when using npm install --no-optional because the used luxon package was missing. So I reverted node-ical back to 0.13.0 in develop.

Today I digged deeper into this and found

  • node-ical v13 uses rrule v2.6.8
  • node-ical v14 uses rrule v2.6.4

So node-ical did a downgrade of rrule due to this issue.

AFAIS there are breaking changes in rrule after v2.6.4 which also may impact this project because the master branch (= latest release) is using rrule v2.6.8.

We have now 2 options:

  • stay on node-ical v13 / rrule v2.6.8
  • use node-ical / rrule v2.6.4 and add missing "luxon": "^1.21.3" to dependencies in package.json as workaround.

I'm to far away from the calendar stuff, so I can't decide this ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant