Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write measurement sets #12

Merged
merged 17 commits into from
Apr 10, 2022
Merged

Write measurement sets #12

merged 17 commits into from
Apr 10, 2022

Commits on Apr 5, 2022

  1. Fix issues surrounding multiple timeblocks.

    When calibrating with multiple timeblocks, the start, end and average
    times of the timeblocks are written to the hyperdrive-formatted
    calibration solutions. However, they weren't written correctly. Using
    shorter key names for these times (e.g. "START_TIMESTAMPS" -> "S_TIMES")
    appears to fix the issue. I don't fully understand why this works; maybe
    there's probably a bad interaction in cfitsio between long key names and
    long strings.
    
    In addition, the way that solutions were propagated across timeblocks
    was incorrect; this is now fixed.
    cjordan committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    16d004a View commit details
    Browse the repository at this point in the history
  2. Move vis weighting outside calibration.

    Multiply visibilities by weights before calibration and divide by
    weights if writing visibilities out. This means weights are needed
    during calibration and the code is able to run about 25% faster.
    
    Note that there are relatively big (up to 1e-4) float-point errors
    introduced by doing this; writing visibilities out of di-calibration
    should therefore only be done as a "quick and dirty" convenience. When
    solutions-apply is introduced, that will be the preferred way to obtain
    calibrated visibilities.
    cjordan committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    5781f9a View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Remove autocorrelation considerations for DI cal.

    Autocorrelations will only be calibrated and written out as part of a
    to-be-written solutions-apply command.
    
    Fix one test passing --cpu to SimulateVisArgs when it was not expected.
    cjordan committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    70a623f View commit details
    Browse the repository at this point in the history
  2. Fix issues around averaging factors.

    The parse_{time,freq}_average_factor functions expect {time,freq}
    resolutions, but they weren't getting them, and things weren't working
    as expected. This commit fixes that and an associated test.
    cjordan committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    90c2c21 View commit details
    Browse the repository at this point in the history
  3. remove test file after check

    Dev McElhinney authored and cjordan committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    4ecc9dc View commit details
    Browse the repository at this point in the history
  4. ✅ measurement set output for calibrate vis

    Dev McElhinney authored and cjordan committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    86925b4 View commit details
    Browse the repository at this point in the history
  5. formalize guessing of time_res/freq_res

    Dev McElhinney authored and cjordan committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3aee42a View commit details
    Browse the repository at this point in the history
  6. measurement set writing for simulate-vis

    Dev McElhinney authored and cjordan committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a0fb55f View commit details
    Browse the repository at this point in the history
  7. refactor guess time/freq res into guess interval

    Dev McElhinney committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b61be74 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2022

  1. uvfits timestep reading issue

    Dev McElhinney committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    31de75d View commit details
    Browse the repository at this point in the history
  2. improve precision of uvfits reading code

    round jd_frac before it gets added to PZERO5
    add round_hundredths_of_a_second_duration
    Dev McElhinney committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    356ef3f View commit details
    Browse the repository at this point in the history
  3. fix uvfits reading quantization issue

    Dev McElhinney committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    f0cf606 View commit details
    Browse the repository at this point in the history
  4. cal vis out time avg for sparse time selection

    -> implement time averaging on calibrate-vis output when the
    selected timesteps are non-contiguous.
    Dev McElhinney committed Apr 7, 2022
    Configuration menu
    Copy the full SHA
    ed7ed93 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2022

  1. 📝 fix misaligned bullet points

    Dev McElhinney committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    8fb5ed3 View commit details
    Browse the repository at this point in the history
  2. use correct tempdir for vis writing

    Dev McElhinney committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    e873302 View commit details
    Browse the repository at this point in the history
  3. add support for reading marlu-made measurement sets

    Dev McElhinney committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    dd16697 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2022

  1. Small fixes.

    di-calibrate cannot currently write its sky model to an ms -- the help
    text has been updated to account for this and a test now exists to check
    that the help text is correct.
    
    There were problems around files and directories being overwritten. I've
    done the best I can but it looks like we can't ever handle detecting
    whether we have permission to remove a directory ahead of time. We may
    want to improve an error message associated with attempting to remove a
    directory we don't have permission to, if it's not already clear enough.
    
    A message stating where calibrated visibilities have been written to was
    lost; this is now back.
    cjordan committed Apr 9, 2022
    Configuration menu
    Copy the full SHA
    d5690df View commit details
    Browse the repository at this point in the history