Write measurement sets #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calibrating with multiple timeblocks, the start, end and average times of the timeblocks are written to the hyperdrive-formatted calibration solutions. However, they weren't written correctly. Using shorter key names for these times (e.g. "START_TIMESTAMPS" -> "S_TIMES") appears to fix the issue. I don't fully understand why this works; maybe there's probably a bad interaction in cfitsio between long key names and long strings. In addition, the way that solutions were propagated across timeblocks was incorrect; this is now fixed.
Multiply visibilities by weights before calibration and divide by weights if writing visibilities out. This means weights are needed during calibration and the code is able to run about 25% faster. Note that there are relatively big (up to 1e-4) float-point errors introduced by doing this; writing visibilities out of di-calibration should therefore only be done as a "quick and dirty" convenience. When solutions-apply is introduced, that will be the preferred way to obtain calibrated visibilities.
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
+ Coverage 79.52% 80.31% +0.78%
==========================================
Files 90 93 +3
Lines 16685 17150 +465
==========================================
+ Hits 13269 13774 +505
+ Misses 3416 3376 -40
Continue to review full report at Codecov.
|
Autocorrelations will only be calibrated and written out as part of a to-be-written solutions-apply command. Fix one test passing --cpu to SimulateVisArgs when it was not expected.
The parse_{time,freq}_average_factor functions expect {time,freq}
resolutions, but they weren't getting them, and things weren't working
as expected. This commit fixes that and an associated test.
added 6 commits
April 7, 2022 16:06
round jd_frac before it gets added to PZERO5 add round_hundredths_of_a_second_duration
-> implement time averaging on calibrate-vis output when the selected timesteps are non-contiguous.
d3v-null
force-pushed
the
ms_write
branch
2 times, most recently
from
a652b7b
to
e873302
Compare
di-calibrate cannot currently write its sky model to an ms -- the help text has been updated to account for this and a test now exists to check that the help text is correct. There were problems around files and directories being overwritten. I've done the best I can but it looks like we can't ever handle detecting whether we have permission to remove a directory ahead of time. We may want to improve an error message associated with attempting to remove a directory we don't have permission to, if it's not already clear enough. A message stating where calibrated visibilities have been written to was lost; this is now back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open questions: