Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-Critical MM Patch Re-Ordering & Cleanup #363

Merged
merged 3 commits into from
Apr 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
421 changes: 0 additions & 421 deletions GameData/MOARdV/AvionicsSystems/MAS-NavAid.cfg

This file was deleted.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble following what GitHub says is happening here. You deleted MAS-NavAid.cfg (which contains the radio nav configs), but this file is empty? Or did you rename MAS-NavAid to MAS_NavAid?

File renamed without changes.
259 changes: 0 additions & 259 deletions GameData/MOARdV/FlightSystems/HullcamVDS-MASCamera.cfg

This file was deleted.

17 changes: 0 additions & 17 deletions GameData/MOARdV/FlightSystems/MAS_EngineID.cfg

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// The MAS support piggyback patch. Adds a generic MAS module to any part that
// includes an RPM module.
@PART[*]:HAS[@MODULE[RasterPropMonitorComputer],!MODULE[MASFlightComputer]]:NEEDS[AvionicsSystems]
// includes an RPM module
// Should run very late, to leave room for anything else to patch RPM first. Run 1st in Final pass, before ASET-To-MAS, MAS-to-MAS & MAS_SCANsat patches
@PART[*]:HAS[@MODULE[RasterPropMonitorComputer]&!MODULE[MASFlightComputer]]:FINAL
{
MODULE
{
Expand All @@ -23,7 +24,7 @@
}
}

@PART[JSIPrimitiveExternalCamera]:NEEDS[AvionicsSystems]
@PART[JSIPrimitiveExternalCamera]:FOR[AvionicsSystems]
{
MODULE
{
Expand All @@ -44,7 +45,7 @@

// The JSI to MAS prop upgrade patch. This Module Manager patch replaces
// every core RPM-enabled prop with its equivalent MAS-enabled prop.
@INTERNAL[*]:NEEDS[AvionicsSystems]
@INTERNAL[*]:FINAL // Run 1st in Final pass, before ASET-to-MAS patch, MAS-to-MAS patch, and MAS_SCANsat patch
{
// ---=== JSI/RasterPropMonitor Props ===--- //

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
// The ASET to MAS prop upgrade patch. This Module Manager patch replaces
// every ASET Avionics and ASET Props RPM-enabled prop with its equivalent
// MAS-enabled prop.
@INTERNAL[*]:NEEDS[AvionicsSystems]
// MAS-enabled prop. Should run very late, to leave room for every IVA mod/patch to run first?
// Run 2nd in Final pass, after JSI-to-MAS patch, but before MAS-to-MAS & MAS_SCANsat patches
@INTERNAL[*]:FINAL
{
// TODOs found in the ALCOR IVA that may or may not be supported already.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
// The MAS to MAS prop conversion patch. This Module Manager patch replaces
// old MAS prop names with the updated nomenclature, so the handful of old
// IVAs don't have to be rebuilt.
@INTERNAL[*]:NEEDS[AvionicsSystems]
// Run 3rd in Final pass, after JSI-to-MAS & ASET-to-MAS patches, but before MAS_SCANsat patch
@INTERNAL[*]:FINAL
{
// IndicatorPanel5x3
@PROP[MAS_IP5x3_Alarm],*
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
// Because the RPM bridge for SCANsat uses a local persistent storage module,
// but the SCANsat MM patch only applies to RasterPropMonitor, we need our own
// patch here to get the persistent storage module added to our parts.
@PART[*]:HAS[@MODULE[MASFlightComputer]]:AFTER[AvionicsSystems]:NEEDS[SCANsat]
// Should run very late, after JSI-to-MAS patch, due to MASFlightComputer. Run last in Final pass, after JSI-to-MAS, ASET-to-MAS, MAS-to-MAS patches
@PART[*]:HAS[@MODULE[MASFlightComputer]&!MODULE[SCANRPMStorage]]:NEEDS[SCANsat]:FINAL
{
MODULE
{
Expand Down
17 changes: 17 additions & 0 deletions GameData/MOARdV/Patches/MAS_AJE_IdEngine.cfg
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
// Add MASIdEngine to supported part modules.

@PART[*]:HAS[@MODULE[ModuleEnginesAJEPropeller]&!MODULE[MASIdEngine]]:AFTER[AJE]
{
MODULE
{
name = MASIdEngine
}
}

@PART[*]:HAS[@MODULE[ModuleEnginesAJEJet]&!MODULE[MASIdEngine]]:AFTER[AJE]
{
MODULE
{
name = MASIdEngine
}
}
Loading