Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-Critical MM Patch Re-Ordering & Cleanup #363

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

StoneBlue
Copy link
Contributor

First three items are semi-critical for all/any IVAs to properly function with MAS support

  • Fix issues with Reviva & certain MAS-supported IVAs missing MASFlightComputer, due to patch ordering in MAS
  • Rename some patch file names to reflect proper MM patch ordering within passes
  • Reorder some MAS patches due to relying on MASFlightComputer patch order
  • Remove unnecessary NEEDS/FOR[AvionicsSystems] in some patches
  • Add missing NEEDS or other pass specifiers in some mod support patches
  • Rename/Relocate some mod support patch files for clarity/consistency

- Fix issues with Reviva & certain MAS-supported IVAs missing MASFlightComputer, due to patch ordering in MAS
- Rename some patch file names to reflect proper MM patch ordering within passes
- Reorder some MAS patches due to relying on MASFlightComputer patch order
- Remove unnecessary NEEDS/FOR[AvionicsSystems] in some patches
- Add missing NEEDS or other pass specifiers in some mod support patches
- Rename/Relocate some mod support patch files for clarity/consistency
- Fix issues with Reviva & certain MAS-supported IVAs missing MASFlightComputer, due to patch ordering in MAS
- Rename some patch file names to reflect proper MM patch ordering within passes
- Reorder some MAS patches due to relying on MASFlightComputer patch order
- Remove unnecessary NEEDS/FOR[AvionicsSystems] in some patches
- Add missing NEEDS or other pass specifiers in some mod support patches
- Rename/Relocate some mod support patch files for clarity/consistency
@StoneBlue
Copy link
Contributor Author

StoneBlue commented Mar 19, 2023

HOLD UP!!..
DONT MERGE THIS YET
Seems I may have to do some more extensive testing with Reviva installed, first :(

EDIT: Whew.. so my Reviva folder got corrupted somewhere along the line of moving it in & out of my install at some point..
the Reviva.dll disappeared out of it

All good now, with a fresh install of Reviva... whew!!

@MOARdV MOARdV self-assigned this Mar 19, 2023
@MOARdV MOARdV self-requested a review March 19, 2023 23:13
@MOARdV MOARdV added the bug label Mar 19, 2023
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having trouble following what GitHub says is happening here. You deleted MAS-NavAid.cfg (which contains the radio nav configs), but this file is empty? Or did you rename MAS-NavAid to MAS_NavAid?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit I didn't look too closely at the new props you submitted earlier. Isn't this an RPM patch? Or is this needed because of an RPM to MAS bridge?

@MOARdV MOARdV added this to the v1.3.7 milestone Mar 20, 2023
@MOARdV MOARdV merged commit 9b1e4cb into MOARdV:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants