Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from facebook:master #418

Merged
merged 3 commits into from
Dec 1, 2020
Merged

[pull] master from facebook:master #418

merged 3 commits into from
Dec 1, 2020

Commits on Nov 30, 2020

  1. Disable assert in StubViewTree until it is resolved 

    Summary:
Changelog: [internal]

The assert is still firing, let's disable it until we can investigate why layout animations creates two delete mount instructions.

Reviewed By: majak

Differential Revision: D25216794

fbshipit-source-id: 6328a2afb5eaf7fceebdc05bc75804f2eb44ddd2
    @sammy-SC @facebook-github-bot
    sammy-SC authored and facebook-github-bot committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    5677d81 View commit details
    Browse the repository at this point in the history

  2. Simplify interface of LayoutAnimationKeyFrameManager::getAndEraseConf… 

    …lictingAnimations

Summary:
Changelog: [internal]

Return value from `LayoutAnimationKeyFrameManager::getAndEraseConflictingAnimations` was a tuple with 3 elements. Two of them are not being used so let's get rid of them.

Reviewed By: JoshuaGross

Differential Revision: D25220601

fbshipit-source-id: 35781e735b6a2e518337fdeaf956c18bb370993b
    @sammy-SC @facebook-github-bot
    sammy-SC authored and facebook-github-bot committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    8478f46 View commit details
    Browse the repository at this point in the history

  3. Add DoNotStrip annotations to TurboModulePerfLogger 

    Summary:
Prevent proguard from stripping these methods

Changelog: [Internal] Add DoNotStrip annotations to TurboModulePerfLogger

Reviewed By: RSNara

Differential Revision: D25101027

fbshipit-source-id: 673e97446a36fe0e8c10916aa7eb4c39c2187ba8
    @facebook-github-bot
    Xiaoyu Yin authored and facebook-github-bot committed Nov 30, 2020
    Configuration menu
    Copy the full SHA
    b9b2215 View commit details
    Browse the repository at this point in the history