[pull] master from facebook:master #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: Changelog: [internal] The assert is still firing, let's disable it until we can investigate why layout animations creates two delete mount instructions. Reviewed By: majak Differential Revision: D25216794 fbshipit-source-id: 6328a2afb5eaf7fceebdc05bc75804f2eb44ddd2
…lictingAnimations Summary: Changelog: [internal] Return value from `LayoutAnimationKeyFrameManager::getAndEraseConflictingAnimations` was a tuple with 3 elements. Two of them are not being used so let's get rid of them. Reviewed By: JoshuaGross Differential Revision: D25220601 fbshipit-source-id: 35781e735b6a2e518337fdeaf956c18bb370993b
Summary: Prevent proguard from stripping these methods Changelog: [Internal] Add DoNotStrip annotations to TurboModulePerfLogger Reviewed By: RSNara Differential Revision: D25101027 fbshipit-source-id: 673e97446a36fe0e8c10916aa7eb4c39c2187ba8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )