Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pull] master from facebook:master #405

Merged
merged 3 commits into from
Nov 19, 2020
Merged

[pull] master from facebook:master #405

merged 3 commits into from
Nov 19, 2020

Commits on Nov 19, 2020

  1. RN: Create NativeComponentRegistry 

    Summary:
Creates `NativeComponentRegistry` which makes native component initialization more declarative and configurable through an optionally configurable provider.

The next diff converts `ScrollView` to use this new abstraction as a demonstration. The plan would be to use this to replace all current manual call sites of `registerGeneratedViewConfig`, and then the ones generated via the Babel plugin.

Migrating to this will not change any production behavior, but it will enable verification of `ViewConfig` in development.

Changelog:
[Internal]

Reviewed By: JoshuaGross

Differential Revision: D25084468

fbshipit-source-id: 9c758ddc279bf937a401a868a066907a94098f37
    @yungsters @facebook-github-bot
    yungsters authored and facebook-github-bot committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    6a547c6 View commit details
    Browse the repository at this point in the history

  2. Back out "Back out "[RN] Fabric: Strengthening StubView mutating vali… 

    …dation""

Summary:
Changelog: [internal]

Original commit changeset: b6109a45f153

Reviewed By: JoshuaGross

Differential Revision: D25020497

fbshipit-source-id: c52d5ad03dd1049ac66ecb2d82b5018a05bb4f19
    @sammy-SC @facebook-github-bot
    sammy-SC authored and facebook-github-bot committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    5af6a44 View commit details
    Browse the repository at this point in the history

  3. Do not remove oldChildShadowView from mutation 

    Summary:
Changelog: [internal]

This diff reverts some changes in D23886519 (9f00752), I was not able to repro the issues that D23886519 (9f00752) is fixing.
`oldChildShadowView` must be defined for update mutation.

Reviewed By: JoshuaGross

Differential Revision: D25088008

fbshipit-source-id: 956d0cc536e35376ce0e1cc09f7c5b66cb89fc77
    @sammy-SC @facebook-github-bot
    sammy-SC authored and facebook-github-bot committed Nov 19, 2020
    Configuration menu
    Copy the full SHA
    eaab647 View commit details
    Browse the repository at this point in the history