[pull] master from facebook:master #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Summary: Creates `NativeComponentRegistry` which makes native component initialization more declarative and configurable through an optionally configurable provider. The next diff converts `ScrollView` to use this new abstraction as a demonstration. The plan would be to use this to replace all current manual call sites of `registerGeneratedViewConfig`, and then the ones generated via the Babel plugin. Migrating to this will not change any production behavior, but it will enable verification of `ViewConfig` in development. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D25084468 fbshipit-source-id: 9c758ddc279bf937a401a868a066907a94098f37
…dation"" Summary: Changelog: [internal] Original commit changeset: b6109a45f153 Reviewed By: JoshuaGross Differential Revision: D25020497 fbshipit-source-id: c52d5ad03dd1049ac66ecb2d82b5018a05bb4f19
Summary: Changelog: [internal] This diff reverts some changes in D23886519 (9f00752), I was not able to repro the issues that D23886519 (9f00752) is fixing. `oldChildShadowView` must be defined for update mutation. Reviewed By: JoshuaGross Differential Revision: D25088008 fbshipit-source-id: 956d0cc536e35376ce0e1cc09f7c5b66cb89fc77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )