Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove save() and changes filename in AlignTraj #2486

Merged
merged 7 commits into from
Feb 4, 2020
Merged

Remove save() and changes filename in AlignTraj #2486

merged 7 commits into from
Feb 4, 2020

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 31, 2020 •
edited
Loading

Completes #2099
Addresses part of #1745 #2443

Changes made in this Pull Request:

  • save() method has now been removed.
  • filename should now default to the current working directory.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay requested a review from PicoCentauri January 31, 2020 12:13
@IAlibay
Copy link
Member Author

IAlibay commented Jan 31, 2020

pinging @PicoCentauri for review here since as it appears the filename deprecation was started by them in 0.19.0.

@codecov
Copy link

codecov bot commented Jan 31, 2020 •
edited
Loading

Codecov Report

Merging #2486 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2486   +/-   ##
========================================
  Coverage    90.26%   90.26%           
========================================
  Files          169      169           
  Lines        23214    23214           
  Branches      3009     3009           
========================================
  Hits         20953    20953           
  Misses        1654     1654           
  Partials       607      607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7126ab6...d25ee0f. Read the comment docs.

@IAlibay IAlibay mentioned this pull request Feb 2, 2020
Merged
5 tasks
@richardjgowers richardjgowers merged commit 4c03a2f into MDAnalysis:develop Feb 4, 2020
orbeckst pushed a commit that referenced this pull request Feb 6, 2020
@IAlibay
Remove save part2 (#2494)
e1f1197 
* Partly addresses #1745 (completes save() removal with PR #2487 and PR #2486 )
* removes save methods
  - removes save method from psa.py
  - also minor change to test_hbonds.py
* deprecates hbond_analysis
  - close #2492
* updates changelog
@IAlibay IAlibay mentioned this pull request Mar 5, 2020
Closed
15 tasks
@IAlibay IAlibay deleted the remove-saves branch January 26, 2022 14:17
@fiona-naughton fiona-naughton added maintainability deprecation Deprecated functionality to give advance warning for API changes. labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardjgowers richardjgowers richardjgowers approved these changes

@PicoCentauri PicoCentauri Awaiting requested review from PicoCentauri

Assignees
No one assigned
Labels
deprecation Deprecated functionality to give advance warning for API changes. maintainability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IAlibay @richardjgowers @fiona-naughton