-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation of _reformat_hb in hbonds/hbond_analysis.py for v1.0 #2492
Comments
As this is in the old hbond code, which we will just keep for legacy reasons in 1.0 I would say, just remove the deprecation notice and we freeze it as it is, warts and all. For 2.0 we should consider removing the whole old hbond thing and just use the new hydrogenbond analysis but I don't know what else would need to be updated for this to work. |
Ok thanks, I'll update #2494 accordingly. |
Closing because nothing needs to be done. (Except removing the note) |
Currently going through and doing the required removals/deprecations for #1745 and I noticed that _reformat_hb was set for deprecation as part of #1339
It seems like some change is required here prior to v1.0.0, but it's unclear to me as to what.
The text was updated successfully, but these errors were encountered: