Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes transformation tests not running. #2243

Merged

Conversation

Lp0lp
Copy link
Contributor

@Lp0lp Lp0lp commented Apr 9, 2019

Fixes #2241

Referenced in #2208

Changes made in this Pull Request:

  • Added the missing __init__.py file in /testsuite/MDAnalysisTests/transformations/ that was preventing the transformation tests from running.

  • Updated AUTHORS and CHANGELOG

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Apr 9, 2019

Codecov Report

Merging #2243 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #2243      +/-   ##
==========================================
+ Coverage     89.6%   89.6%   +<.01%     
==========================================
  Files          158     159       +1     
  Lines        19724   19728       +4     
  Branches      2780    2780              
==========================================
+ Hits         17673   17677       +4     
  Misses        1457    1457              
  Partials       594     594
Impacted Files Coverage Δ
transformations/__init__.py 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e405413...c74d5a3. Read the comment docs.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@orbeckst orbeckst merged commit f878cc1 into MDAnalysis:develop Apr 10, 2019
richardjgowers added a commit that referenced this pull request Apr 11, 2019
orbeckst pushed a commit that referenced this pull request Apr 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants