-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses failure of test_load()
in PSA (#2049)
#2239
Conversation
NOTE: load/save fails --- maybe a bug??
test_load()
in PSA (#2049)test_load()
in PSA (#2049)
Codecov Report
@@ Coverage Diff @@
## develop #2239 +/- ##
===========================================
+ Coverage 89.6% 89.67% +0.07%
===========================================
Files 159 159
Lines 19728 19728
Branches 2780 2780
===========================================
+ Hits 17677 17692 +15
+ Misses 1457 1440 -17
- Partials 594 596 +2
Continue to review full report at Codecov.
|
Thanks @sseyler , I'll wait for CI to finish. Feel free to ping me. |
Weird travis failure on macOS 960.10 (Python 2.7) and 960.9 (Python 3.6)
even though the installation logs indicate that
@MDAnalysis/coredevs any idea what's wrong here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This passed CI on Linux and Windows but macOS has a weird failure not related to this PR so I am approving it for right now. Thanks @sseyler !
I pushed this feature branch to my fork and opened a PR to the same master branch on my fork & so far the Mac job there is doing just fine with pytest running the suite: tylerjereddy#2 Maybe a restart is warranted, and if it starts showing up more regularly we can open an issue. |
Commit history isn't the cleanest, but CI is all green now if that's what you were waiting for. |
Many thanks @tylerjereddy . I'll quickly compact the history a bit. |
ae2a37d
to
4c4a510
Compare
We're getting the MacOS failures again--have those happened in any PR other than this one? |
yes:
|
I have to resolve the merge conflict in this PR so CI will run again anyway... |
Now AppVeyor doesn't want to run... will rebase manually. |
f2c44ec
to
b49a6b0
Compare
macOS still failing |
Fixes #2049 and also boosts PSA code coverage (#1006).
Changes made in this Pull Request:
test_load()
now passes after callingsave_paths()
with default argumentsPSAnalysis
now has default base filename and prefix for consistency with default saving behavior ofPSAnalysis.generate_paths()
Path.fit_to_reference()
withMDAnalysis.analysis.AlignTraj
PSAnalysis.generate_paths()
withMDAnalysis.analysis.AlignTraj
PR Checklist