Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Google Motion Photo #954

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Fix Google Motion Photo #954

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d25f79a
Fix Google Motion Photo
tmp-hallenser Apr 1, 2021
cab0c42
Adding correct check (was wrong function name)
ildyria Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions app/Actions/Photo/Extensions/VideoEditing.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,17 +118,13 @@ public function extractVideo(Photo $photo, int $videoLengthBytes, string $frame_

if ($frame_tmp === '') {
$filename = $photo->url;
//! why is this dead code?
$url = Storage::path('big/' . $filename);
} else {
$filename = $photo->thumbUrl;
//! why is this dead code?
$url = $frame_tmp;
}

$filename_video_mov = basename($filename, Helpers::getExtension($filename, false)) . '.mov';

$uploadFolder = $this->permissionCheck('big/');
$uploadFolder = Storage::path('big/');

try {
// 1. Extract the video part
Expand Down