Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Google Motion Photo #954

Merged
merged 2 commits into from
Apr 25, 2021
Merged

Fix Google Motion Photo #954

merged 2 commits into from
Apr 25, 2021

Conversation

tmp-hallenser
Copy link
Contributor

  • Removed dead code
  • Fix call of function to get path

@tmp-hallenser
Fix Google Motion Photo
d25f79a 
* Removed dead code
* Fix call of function to get path
@codecov
Copy link

codecov bot commented Apr 1, 2021 •
edited
Loading

Codecov Report

Merging #954 (cab0c42) into master (376f8c7) will decrease coverage by 1.69%.
The diff coverage is 0.00%.

d7415
d7415 reviewed Apr 1, 2021
View reviewed changes
Copy link
Contributor

@d7415 d7415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems simple enough (though I'll let someone more familiar with the code take a closer look!)

@ildyria
Copy link
Member

ildyria commented Apr 6, 2021

@tmp-hallenser please check my commit, feel free to revert if needed, otherwise merge. 👍

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tmp-hallenser
Copy link
Contributor Author

tmp-hallenser commented Apr 25, 2021 •
edited
Loading

Should be good to go. Thanks.

@ildyria ildyria merged commit 5b63694 into master Apr 25, 2021
@ildyria ildyria deleted the fix-google-motion-photo branch April 25, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmp-hallenser @ildyria @d7415