Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade version #721

Merged
merged 5 commits into from
Sep 17, 2020
Merged

Upgrade version #721

merged 5 commits into from
Sep 17, 2020

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Sep 10, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 10, 2020 •
edited
Loading

Codecov Report

Merging #721 into master will decrease coverage by 0.40%.
The diff coverage is 42.99%.

@ildyria ildyria mentioned this pull request Sep 11, 2020
Merged
@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2020 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

kamil4
kamil4 approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor

@kamil4 kamil4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I provided some comments as a proof that I actually read through it but overall it looks good...

app/Console/Commands/Diagnostics.php Show resolved Hide resolved
app/Console/Commands/ResetAdmin.php Show resolved Hide resolved
app/Console/Commands/ShowLogs.php Show resolved Hide resolved
app/ControllerFunctions/Update/Check.php Show resolved Hide resolved
app/Http/Middleware/RedirectIfAuthenticated.php Show resolved Hide resolved
database/factories/UserFactory.php Show resolved Hide resolved
database/migrations/2020_07_26_085322_config_swipe_tolerance.php Show resolved Hide resolved
public/web.config Show resolved Hide resolved
tests/Feature/RSSTest.php Show resolved Hide resolved
tests/Feature/UpdateTest.php Show resolved Hide resolved
@ildyria
Copy link
Member Author

ildyria commented Sep 17, 2020

@kamil4 Some answers for you.

@ildyria ildyria merged commit dd979ab into master Sep 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the upgrade-laravel-8 branch September 17, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamil4 kamil4 kamil4 approved these changes

@d7415 d7415 Awaiting requested review from d7415

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @kamil4