Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

some dependencies move from dependencies to devDependencies #220

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

yoshinorin
Copy link
Contributor

Description

Move some dependencies from dependencies to devDependencies in package.json

Reason

The devDependencies are just for development dependency that like gulp (task runner), babel (transpiler), etc...
It is similar to require and require-dev relationship in composer.json for PHP.

IMHO, it is better to separate them for developers.

Thank you :)

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ildyria
Copy link
Member

ildyria commented Sep 3, 2020

To be honest, I'm not sure it matters as we are just using node to compile our JS. 😅

@d7415
Copy link
Contributor

d7415 commented Sep 3, 2020

To be honest, I'm not sure it matters as we are just using node to compile our JS. sweat_smile

That was my immediate reaction. If you're using this repo and aren't developing, you're doing it wrong!

@kamil4
Copy link
Contributor

kamil4 commented Sep 3, 2020

Well, some users may be using this repo simply to stay at the cutting edge of our development (say, to try out a proposed patch for a bug they reported). Does the split make sense then?

@d7415
Copy link
Contributor

d7415 commented Sep 3, 2020

Well, some users may be using this repo simply to stay at the cutting edge of our development (say, to try out a proposed patch for a bug they reported). Does the split make sense then?

Do we even look in there? (aside from apple-touch-icon-* which should be in dist...)

@yoshinorin
Copy link
Contributor Author

IMHO, if separate dependencies and devDependencies we can understand a little easier which packages affect application behavior. I think this is also useful when upgrading a package version.

Generally, We have to check & test application behavior when update the package's version. But, devDependencies are no need. Because devDependencies are just for development, not change the application behavior.

But, I cant come up with other advantages.

@ildyria
Copy link
Member

ildyria commented Sep 11, 2020

(aside from apple-touch-icon-* which should be in dist...)

Actually they are in img/ and it is fixed with LycheeOrg/Lychee#721

@ildyria ildyria merged commit 46caf97 into LycheeOrg:master Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants