add an option to the sync command to 're-sync' images that already exist #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
812
to
815
| $info = $this->metadataExtractor->bare(); | ||
| $this->metadataExtractor->size($info, $path); | ||
| $this->metadataExtractor->validate($info); | ||
| $info['type'] = 'raw'; |
There was a problem hiding this comment.
#574 changes support of raw files, i.e. metadata is also extracted for raw files if possible. See
Lychee/app/ModelFunctions/PhotoFunctions.php
Lines 286 to 289 in 32b460e
There was a problem hiding this comment.
@tmp-hallenser I adjusted my code to match the #574
|
It looks like this may have been an issue downloading EXIFtool and not the code changes? |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since XMP sidecars are now allowed, images with the same checksum will not get updated metadata if the sidecar changes but the checksum remains the same. This adds an optional flag to the
lychee:synccommand that forces existing images with no change in checksum to get updated metadata from XMP files (if they exist). It only updates the image if the metadata read in differs from the metadata that the image aleady has.