Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix support of raw files #574

Merged
merged 23 commits into from
May 26, 2020
Merged

Fix support of raw files #574

merged 23 commits into from
May 26, 2020

Conversation

tmp-hallenser
Copy link
Contributor

No description provided.

@tmp-hallenser tmp-hallenser mentioned this pull request May 18, 2020
Closed
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #574 into master will decrease coverage by 0.33%.
The diff coverage is 32.46%.

@ildyria
Copy link
Member

ildyria commented May 19, 2020

Code wise, no complaints.

I will test it tomorrow with uploading a pdf and some text files ! :D

@tmp-hallenser
Copy link
Contributor Author

Unfortunately, there some more work to do. So far, I only fixed the extraction of metadata.

Open is still the creation of jpgs.

@ildyria
Copy link
Member

ildyria commented May 20, 2020

At least the current code does not break when I upload ... e.g. pdf. 👍

@tmp-hallenser
Copy link
Contributor Author

Added the missing lines to create medium, small and thumb jpg files in case of raw files.

Front-end needs to be updated to show work correctly.

Currently, it requires exiftool to work since we need the image dimensions.

@tmp-hallenser
Copy link
Contributor Author

Just created a PR for php-exif with imagick as an additional adapter. This will allow uploading raw files without exiftool being installed (some minor changes needed).

@ildyria ildyria self-requested a review May 21, 2020 11:27
@ildyria
Copy link
Member

ildyria commented May 21, 2020

Works fine. I don't have actual raw image to test with on this laptop.

@ildyria
Copy link
Member

ildyria commented May 21, 2020

@tmp-hallenser merge when you feel like it is ready. 👍

@tmp-hallenser
Copy link
Contributor Author

Now it should be ready for testing

@tmp-hallenser tmp-hallenser mentioned this pull request May 23, 2020
Merged
ildyria
ildyria approved these changes May 23, 2020
View reviewed changes
setup_exiftool.sh Show resolved Hide resolved
@tmp-hallenser tmp-hallenser mentioned this pull request May 24, 2020
Closed
@tmp-hallenser
Merge branch 'master' into fix-564
4186b38
@tmp-hallenser
Update composer.lock and front js files
c774120
@tmp-hallenser
Merge branch 'master' into fix-564
4ab4390
@tmp-hallenser
Update composer.lock
874d3fb
@tmp-hallenser
Bugfixes
6752959 
* Make raw file extensions case insensitive
* Added try-catch for scaling
* Added try-catch for path of xmp file
@tmp-hallenser
Added attempt to create video preview at t=0
6365bff 
In case video thumbnail extaction at middle of video fails, we try a second thumbnail at the beginning of the video
@tmp-hallenser
Copy link
Contributor Author

The PR is now ready to merge. Any objections? @ildyria

@sonarcloud
Copy link

sonarcloud bot commented May 26, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ildyria ildyria merged commit 16c7c92 into master May 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-564 branch May 26, 2020 09:40
@kamil4 kamil4 mentioned this pull request Oct 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ildyria ildyria ildyria approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmp-hallenser @codecov-commenter @ildyria @zhanglix