Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How about we don't execute tests twice? #1982

Merged
merged 1 commit into from
Aug 20, 2023
Merged

How about we don't execute tests twice? #1982

merged 1 commit into from
Aug 20, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Aug 19, 2023 •
edited
Loading

Yeah pretty dumb copy paste.

This should cut the execution time of tests by 25%...

@ildyria ildyria added Review: easy Easy review expected: probably just need a quick to go through. High Priority High priority issues labels Aug 19, 2023
@ildyria ildyria requested a review from a team August 19, 2023 19:55
@codecov
Copy link

codecov bot commented Aug 19, 2023 •
edited
Loading

Codecov Report

Merging #1982 (3b01fc5) into master (6191172) will decrease coverage by 0.35%.
The diff coverage is n/a.

Additional details and impacted files

@ildyria ildyria mentioned this pull request Aug 19, 2023
Merged
@ildyria ildyria merged commit 3b99b18 into master Aug 20, 2023
29 checks passed
@ildyria ildyria deleted the 2x-speed-on-tests branch August 20, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d7415 d7415 d7415 approved these changes

Assignees
No one assigned
Labels
High Priority High priority issues Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @d7415