Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes on List sharing permissions. #1981

Merged
merged 10 commits into from
Aug 21, 2023
Merged

Minor fixes on List sharing permissions. #1981

merged 10 commits into from
Aug 21, 2023

Conversation

ildyria
Copy link
Member

@ildyria ildyria commented Aug 19, 2023 •
edited
Loading

Requires: #1982

@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Aug 19, 2023
@codecov
Copy link

codecov bot commented Aug 19, 2023 •
edited
Loading

Codecov Report

Merging #1981 (835de41) into master (6191172) will decrease coverage by 0.38%.
Report is 1 commits behind head on master.
The diff coverage is 73.33%.

❗ Current head 835de41 differs from pull request most recent head 4b69aa6. Consider uploading reports for the commit 4b69aa6 to get more accurate results

Additional details and impacted files

@ildyria ildyria marked this pull request as ready for review August 19, 2023 21:15
@ildyria ildyria requested a review from a team August 19, 2023 21:15
qwerty287
qwerty287 approved these changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but didn't test

@ildyria
Copy link
Member Author

ildyria commented Aug 21, 2023

Looks good, but didn't test

That's what the amazing tests by @nagmat84 are for. 😄
( I did check things were still working though )

@ildyria ildyria merged commit 12bd6d4 into master Aug 21, 2023
11 checks passed
@ildyria ildyria deleted the fix-share-with-user-perm branch August 21, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwerty287 qwerty287 qwerty287 approved these changes

Assignees
No one assigned
Labels
Review: easy Easy review expected: probably just need a quick to go through.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ildyria @qwerty287