Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix URLs in RSS feeds (#1732) #1738

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Conversation

nicokaiser
Copy link
Contributor

URLs in RSS feeds are "https://example.com/#xyzzy/aabbcc".

This works in default installations, however the canonical URL to albums (and photos) starts with "/gallery", so these URLs should be
"https://example.com/gallery#xyzzy/aabbcc".

When using the landing page, URLs even need to include "gallery", otherweise all of the RSS URLs only show the landing page.

URLs in RSS feeds are "https://example.com/#xyzzy/aabbcc". This works in
default installations, however the canonical URL to albums (and photos)
starts with "/gallery", so these URLs should be
"https://example.com/gallery#xyzzy/aabbcc".

When using the landing page, URLs even _need_ to include "gallery",
otherweise all of the RSS URLs only show the landing page.
@nicokaiser
Copy link
Contributor Author

nicokaiser commented Jan 26, 2023

See also Lychee-front#379

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #1738 (ac503be) into master (0b973da) will decrease coverage by 0.33%.
The diff coverage is 100.00%.

Additional details and impacted files

@ildyria ildyria merged commit c77764b into LycheeOrg:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants