[Enhancement] Consistent URLs when Landing Page is disabled

[nicokaiser]

When the Landing Page is enabled, the Gallery and all its URLs are https://example.com/gallery#xyzzy and https://example.com/gallery#xyzzy/aabbcc.
When the Landing Page is disabled, the URLs are https://example.com/#xyzzy and https://example.com/#xyzzy/aabbcc, but this is only due to the IndexController also delivering the Gallery in this case. The gallery# URLs still seem to be the canonical URLs.

Also, redirects are going to the gallery# versions. https://example.com/r/xyzzy -> https://example.com/gallery#xyzzy
When enabling the Landing Page at a later time, previous URLs like https://example.com/#xyzzy do not work anymore.

Wouldn't it be more consistent to have all URLs generated by the frontend include the gallery prefix? There are two options:

1. Currently IndexController renders the frontend when Landing Page is disabled. This could be replaced by a redirect('gallery'). This would be the "cleanest" way to achieve this, however when using this option, there is not real "homepage" anymore (because / redirects to /gallery). (The return type of the method also needs to be adjusted)

Lychee/app/Http/Controllers/IndexController.php

Line 68 in dc33883

return $this->frontend();

- 			return $this->frontend();
+ 			return redirect('gallery');

or 2. Change lychee.goto so it includes the prefix:

https://github.com/LycheeOrg/Lychee-front/blob/5ade25d897bc04df9cab15bda0dc0fb6c5e0b16a/scripts/main/lychee.js#L756

- 	url = "#" + (url !== null ? url : "");
+ 	url = "gallery#" + (url !== null ? url : "");

I'm not sure if the latter has implications on other URLs generated using lychee.goto, however I guess (!) this method is only used to generate album or photo URLs.

[ildyria]

Will be fixed with the Livewire front-end I am working on.
This will be made consistent.

[nicokaiser]

Great to hear! Anything I can help with on the Livewire task?

[ildyria]

I am currently doing the header modal forms and will be working on the sidebar editing soon after, though I am considering adding a drop down-setting effect on the Album page to give a view of all modifiable settings in one go.

I have not yet worked on the sharing page, nor have I implemented the landing page or the frame page.
If you want to give me a bit of help I would suggest to have a look at those two (landing, frame) and how to integrate them in the index page.
They should be fairly easy to implement and would give you some insight of how the new front-end work (which is very different to the JS one).

The following page should give you some insight of how it works and the architecture behind it.
https://lycheeorg.github.io/docs/livewire.html

[nicokaiser]

One addition: the URLs in the RSS feeds are all wrong on 4.7.0, if the landing page is enabled (@ildyria you can see this in your own RSS feed). Maybe this should be hot-fixed even before the new Livewire frontend is ready (which might take some weeks to months, right?)

[nicokaiser]

#1738
LycheeOrg/Lychee-front#379