Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Default to RSS 2.0 to support enclosure tag #584

Closed
bennettscience opened this issue May 22, 2020 · 4 comments
Closed

[Enhancement] Default to RSS 2.0 to support enclosure tag #584

bennettscience opened this issue May 22, 2020 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bennettscience
Copy link
Contributor

I'm glad to see feeds in the last release!

The feed defaults to Atom 1.0, which doesn't support linking media. What do you think about defaulting to RSS 2.0 which would allow the actual image to be sent along in the feed? It would take a couple template tweaks in the laravel-feed views and a couple lines in the controller file.

@ildyria
Copy link
Member

ildyria commented May 22, 2020

Feel free to open a PR ! 😃

@ildyria ildyria added enhancement New feature or request good first issue Good for newcomers labels May 22, 2020
@bennettscience
Copy link
Contributor Author

Because I'm still not super familiar with Laravel, if I update the templates in the vendor/ directory, will those be overwritten if you update the package with composer in the future?

@ildyria
Copy link
Member

ildyria commented May 22, 2020

anything in vendor should not be edited as this will not be taken by Git for once and this will likely be overwritten by composer yes.

@ildyria
Copy link
Member

ildyria commented May 22, 2020

What you can do however is :

php artisan vendor:publish --provider="Spatie\Feed\FeedServiceProvider" --tag="views"

This will publish the rss views in the resources/ folder, allowing you to modify them.

ildyria pushed a commit that referenced this issue May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants