More permanent fix for #584 #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Default view to RSS instead of Atom to include enclosure
Adding a link to the public image fails if the album does not allow original image downloads. The enclosure tag is only added to the feed if downloads are allowed.
Photos can only be attached in the <enclosure> tag if the album allows anyone to download the file. This checks for album permissions before creating an enclosure object to send.
Albums that do not allow photo downloads cannot be included as enclosures. This checks album permissions before creating the enclosure to add to the feed.
Disabling photo download is just removing the access to the big source. We can still provide the medium one. That is what the downgrade is doing. |
ildyria
reviewed
May 27, 2020
Remove redundant `null` assignment. Co-authored-by: Benoît Viguier <ildyria@users.noreply.github.com>
Co-authored-by: Benoît Viguier <ildyria@users.noreply.github.com>
Co-authored-by: Benoît Viguier <ildyria@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
ildyria
approved these changes
May 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Albums that do not allow photo downloads cannot be included as enclosures. This checks album permissions before creating the enclosure to add to the feed.