Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

[WIP] Flux feature parity #13

Merged
merged 12 commits into from
Feb 27, 2024
Merged

[WIP] Flux feature parity #13

merged 12 commits into from
Feb 27, 2024

Conversation

MartinuzziFrancesco
Copy link
Member

Addressing #12

src/initializers.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 97.29730% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 96.52%. Comparing base (273a0cf) to head (2af0c18).

Files Patch % Lines
ext/WeightInitializersCUDAExt.jl 93.75% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   95.77%   96.52%   +0.75%     
==========================================
  Files           4        4              
  Lines          71      144      +73     
==========================================
+ Hits           68      139      +71     
- Misses          3        5       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinuzziFrancesco
Copy link
Member Author

I think I could streamline the tests a little, there are sections that can be shortened a bit. Beside that, create_bias is missing, but I think that is more a DL library specific implementation

@avik-pal
Copy link
Member

yeah create_bias is a bit specific. Can you rebase, then we should be good?

@MartinuzziFrancesco
Copy link
Member Author

This should be good to go now, I can't see the failed tests on buldkite thou

@avik-pal
Copy link
Member

I made buildkite public, but rn the cuda clusters have a disk space issue. Let's merge it once that is resolved

src/initializers.jl Outdated Show resolved Hide resolved
@@ -1,6 +1,7 @@
module WeightInitializers

import PrecompileTools: @recompile_invalidations
using PartialFunctions, Random, SpecialFunctions, Statistics, LinearAlgebra
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is not needed, right? Just LinearAlgebra needs to be put inside @recompile_invalidations

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, I missed a couple of details in the rebase apparently. I fixed that and also added the missing inits to the non differentiable list

@avik-pal avik-pal merged commit 438aaac into main Feb 27, 2024
15 checks passed
@avik-pal avik-pal deleted the fm/fp branch February 27, 2024 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants