-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Flux feature parity #13
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13 +/- ##
==========================================
+ Coverage 95.77% 96.52% +0.75%
==========================================
Files 4 4
Lines 71 144 +73
==========================================
+ Hits 68 139 +71
- Misses 3 5 +2 ☔ View full report in Codecov by Sentry. |
I think I could streamline the tests a little, there are sections that can be shortened a bit. Beside that, |
yeah |
8d68d66
to
a199793
Compare
This should be good to go now, I can't see the failed tests on buldkite thou |
I made buildkite public, but rn the cuda clusters have a disk space issue. Let's merge it once that is resolved |
src/WeightInitializers.jl
Outdated
@@ -1,6 +1,7 @@ | |||
module WeightInitializers | |||
|
|||
import PrecompileTools: @recompile_invalidations | |||
using PartialFunctions, Random, SpecialFunctions, Statistics, LinearAlgebra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this line is not needed, right? Just LinearAlgebra needs to be put inside @recompile_invalidations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, I missed a couple of details in the rebase apparently. I fixed that and also added the missing inits to the non differentiable list
Addressing #12