Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter_flags: Bug fixing #78

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Flutter_flags: Bug fixing #78

merged 1 commit into from
Jul 17, 2022

Conversation

ByJerome
Copy link
Contributor

@ByJerome ByJerome commented Jul 7, 2022

All flags are working without any errors either on 4x3 or 1x1 format. & nearly all issues are resolved with this pr.

This is the first pull request I have ever made. Be kind with me 😄

- LunaGao#70 removed almost all clipPath-tags at the <defs> (Flags were cut off)
- LunaGao#77 changed the pt values to pixel (1pt ~= 1.3333333px)
- Added around 60 missing flags into the FlagsCode Enum
- Updated flutter_svg to version 1.0.3
- Updated the flags (6.6.3) provided by https://github.com/lipis/flag-icons

All flags are working without any errors either on 4x3 or 1x1 format.
@JulianBissekkou
Copy link

Nice! @LunaGao Can you give this a review?

@LunaGao LunaGao merged commit 988b830 into LunaGao:stable Jul 17, 2022
@daniel-hopkins
Copy link

I see this merge, but the version on pub.dev has not been updated.
Is that correct?

@mahanabd
Copy link

why the library not update flutter_svg?

@stefanschaller
Copy link
Contributor

Any information why flutter_svg are not up to date?

@LunaGao
Copy link
Owner

LunaGao commented Jun 12, 2023

Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants