Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with JP flag rendering, along some others, in 6.0.0 #70

Closed
nimeacuerdo opened this issue Feb 20, 2022 · 0 comments
Closed

Issue with JP flag rendering, along some others, in 6.0.0 #70

nimeacuerdo opened this issue Feb 20, 2022 · 0 comments

Comments

@nimeacuerdo
Copy link

Hi,

After switching from version 5.0.1 to 6.0.0 I am seeing some flags being incorrectly rendered in my app.

This is an example of Japan (the red spot should be centered):

Screenshot 2022-02-20 at 19 55 35

whereas others, like Mexico, work fine:

Screenshot 2022-02-20 at 19 55 24

The flag is being rendered inside a TabBar like this:

Tab(
  icon: Flag.fromString(
  UpdateService().getLocation(),
  width: SizeConfig.blockSizeHorizontal * 10,
  height: SizeConfig.blockSizeVertical * 5,
)),

Thanks in advance!
ByJerome pushed a commit to ByJerome/flag_flutter that referenced this issue Jul 7, 2022
Flutter_flags: Bug fixing
d81fae5 
- LunaGao#70 removed almost all clipPath-tags at the <defs> (Flags were cut off)
- LunaGao#77 changed the pt values to pixel (1pt ~= 1.3333333px)
- Added around 60 missing flags into the FlagsCode Enum
- Updated flutter_svg to version 1.0.3
- Updated the flags (6.6.3) provided by https://github.com/lipis/flag-icons

All flags are working without any errors either on 4x3 or 1x1 format.
@ByJerome ByJerome mentioned this issue Jul 7, 2022
Merged
@LunaGao LunaGao closed this as completed Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nimeacuerdo @LunaGao