Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll service fixes #7

Closed
wants to merge 6 commits into from
Closed

fix: scroll service fixes #7

wants to merge 6 commits into from

Conversation

alihassan143
Copy link

No description provided.

@alihassan143
Copy link
Author

@LucasXu0

@LucasXu0
Copy link
Owner

@alihassan143 any related issues?

@alihassan143
Copy link
Author

@LucasXu0 scroll service did not scroll automatically when users start writing now its working perfectly on mobile and desktop

@alihassan143
Copy link
Author

@LucasXu0 why there is more horizontal padding even you add padding in editor style

@alihassan143 alihassan143 changed the title feat: scroll service fixes fix: scroll service fixes May 20, 2023
@alihassan143
Copy link
Author

@LucasXu0 image builder shows error when alignment is not provided converting from html to node now that bug fixes

@LucasXu0
Copy link
Owner

Hey, @alihassan143. Would you mind submitting the PR to the appflowy-editor repo after this PR merged? AppFlowy-IO#129. Because this repo doesn't include any CI checks.

@LucasXu0
Copy link
Owner

And please refrain from adding the override function such as insertContent since we are currently using Flutter 3.7.x.

@alihassan143
Copy link
Author

@LucasXu0 actually i am using latest flutter version that why this added
ok i will do that

@alihassan143 alihassan143 closed this by deleting the head repository May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants