Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preconditions: Refactor the editor part for supporting the mobile. #129

Merged
merged 190 commits into from
May 24, 2023

Conversation

LucasXu0
Copy link
Collaborator

#97

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #129 (72a9f2c) into main (51c9264) will decrease coverage by 26.45%.
The diff coverage is 64.34%.

@@             Coverage Diff             @@
##             main     #129       +/-   ##
===========================================
- Coverage   86.88%   60.43%   -26.45%     
===========================================
  Files         127      208       +81     
  Lines        7379     9320     +1941     
===========================================
- Hits         6411     5633      -778     
- Misses        968     3687     +2719     
Impacted Files Coverage Δ
lib/src/core/document/deprecated/document.dart 0.00% <0.00%> (ø)
lib/src/core/document/deprecated/node.dart 0.00% <0.00%> (ø)
lib/src/core/legacy/built_in_attribute_keys.dart 0.00% <ø> (-100.00%) ⬇️
lib/src/core/location/position.dart 87.50% <0.00%> (-12.50%) ⬇️
...service/ime/delta_input_on_action_update_impl.dart 0.00% <0.00%> (ø)
...ponent/service/ime/delta_input_on_delete_impl.dart 0.00% <0.00%> (ø)
...rvice/ime/delta_input_on_non_text_update_impl.dart 0.00% <0.00%> (ø)
...omponent/service/scroll/mobile_scroll_service.dart 0.00% <0.00%> (ø)
...nt/service/selection/mobile_selection_service.dart 0.00% <0.00%> (ø)
...b/src/editor/toolbar/desktop/floating_toolbar.dart 0.00% <0.00%> (ø)
... and 146 more

... and 44 files with indirect coverage changes

@LucasXu0
Copy link
Collaborator Author

FYI, @Xazin @MayurSMahajan this PR is ready for review.

LucasXu0 and others added 3 commits May 24, 2023 00:09
* chore: add mobile icon files

* chore: add AFMobileIcon and draft toolbar UI

* chore: move toolbar items out of MobileToolbar
@LucasXu0 LucasXu0 merged commit b3d4529 into AppFlowy-IO:main May 24, 2023
@hyj1204 hyj1204 linked an issue Jun 1, 2023 that may be closed by this pull request
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] migration: link menu and color picker
2 participants