New setup dynamic forms #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NicholasLin718
commented
Mar 5, 2023
NicholasLin718
commented
- Implemented new API instance manifest integration to dynamically generate forms based on the sections provided by the manifest
- Added a new sidebar and select game instance page + styling
…e-Team/dashboard into new-setup-dynamic-forms
✅ Deploy Preview for lodestone-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for lodestone-dashboard ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Ynng
requested changes
Mar 5, 2023
There was a problem hiding this comment.
A few more things not mentioned in the comments:
-
Currently no minecraft instance is created for me.
When I click "createInstance", pretty much nothing happens. From devtools I can see the validation requests being made but not the creation request. -
Would be nice to remove the console logs after we are done with it
src-tauri/Cargo.toml
Outdated
| @@ -20,7 +20,7 @@ serde = { version = "1.0", features = ["derive"] } | |||
| tauri = { version = "1.1.1", features = ["api-all", "devtools"] } | |||
| tauri-plugin-localhost = "0.1.0" | |||
| portpicker = "0.1" | |||
| lodestone_core = {git = "https://github.com/Lodestone-Team/lodestone_core", branch = "main"} | |||
| lodestone_core = {git = "https://github.com/Lodestone-Team/lodestone_core", branch = "dev/refactor-setup"} | |||
There was a problem hiding this comment.
We should probably change this to release/0.4.3, and backend should merge dev/refactor-setup in to 0.4.3 @CheatCod
Arcslogger
approved these changes
Mar 7, 2023
…e-Team/dashboard into new-setup-dynamic-forms
New dynamic settings
Ynng
requested changes
Mar 11, 2023
…ent for radio fields
…nto new-setup-dynamic-forms
Setup form styling - new input fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.