Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New dynamic settings [Merge this before "New setup dynamic forms"] #189

Merged
merged 7 commits into from
Mar 10, 2023
Merged

New dynamic settings [Merge this before "New setup dynamic forms"] #189

merged 7 commits into from
Mar 10, 2023

Conversation

NicholasLin718
Copy link
Contributor

  • Dynamically generated objects to be mapped as Setting Fields using the configurable manifest fetched
  • Added float validation
  • Removed useGameSettings -> Replaced by retrieving all data from configurable manifest

Ynng
Ynng approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@Ynng Ynng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

netlify bot didn't trigger :( but code looks about right
I'll take another look in the dynamic-form pr once this is merged

@NicholasLin718 NicholasLin718 merged commit cbb75f2 into new-setup-dynamic-forms Mar 10, 2023
@Ynng Ynng deleted the new-dynamic-settings branch May 12, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ynng Ynng Ynng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NicholasLin718 @Ynng