Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release_notes): ensure tag prefix is included #129

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

The comparison URL in the generated release notes is missing the "v" prefix in the second tag.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (874be46) to head (a898d58).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #129   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines          174       174           
=========================================
  Hits           174       174           
Files Coverage Δ
action/main.py 100.00% <ø> (ø)

@ReenigneArcher ReenigneArcher force-pushed the fix(release_notes)-ensure-tag-prefix-is-included branch from 6bbfb0a to a898d58 Compare August 1, 2024 19:17
@ReenigneArcher ReenigneArcher merged commit 2b96d23 into master Aug 1, 2024
11 checks passed
@ReenigneArcher ReenigneArcher deleted the fix(release_notes)-ensure-tag-prefix-is-included branch August 1, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant