fix(release_notes): ensure tag prefix is included

LizardByte · Aug 1, 2024 · 6bbfb0a · 6bbfb0a
1 parent 874be46
commit 6bbfb0a
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/action/main.py b/action/main.py
@@ -421,18 +421,18 @@ def main() -> dict:
     release_tag = f"{release_version}"
 
     # generate release notes
+    version_prefix = os.getenv('INPUT_TAG_PREFIX', 'v')
     if push_event_details['publish_release']:
         release_body = generate_release_body(
-            tag_name=release_tag,
+            tag_name=f"{version_prefix}{release_tag}",
             target_commitish=push_event_details["release_commit"],
         )
     else:
         release_body = ''
     release_generate_release_notes = True if not release_body else False
 
-    version_prefix = ''
-    if os.getenv('INPUT_INCLUDE_TAG_PREFIX_IN_OUTPUT', 'true').lower() == 'true':
-        version_prefix = os.getenv('INPUT_TAG_PREFIX', 'v')
+    if os.getenv('INPUT_INCLUDE_TAG_PREFIX_IN_OUTPUT', 'true').lower() != 'true':
+        version_prefix = ''
 
     job_outputs['publish_release'] = str(push_event_details['publish_release']).lower()
     job_outputs['release_body'] = release_body

diff --git a/tests/data/expected_release_notes_sample_0.md b/tests/data/expected_release_notes_sample_0.md
@@ -147,7 +147,7 @@
 * [@cathyjf](https://github.com/cathyjf) made their first contribution in [#2786](https://github.com/LizardByte/Sunshine/pull/2786)
 * [@cfalas](https://github.com/cfalas) made their first contribution in [#2841](https://github.com/LizardByte/Sunshine/pull/2841)
 
-**Full Changelog**: https://github.com/LizardByte/Sunshine/compare/v0.23.1...2024.713.195308
+**Full Changelog**: https://github.com/LizardByte/Sunshine/compare/v0.23.1...v2024.713.195308
 
 
 ---

diff --git a/tests/data/provided_release_notes_sample_0.md b/tests/data/provided_release_notes_sample_0.md
@@ -147,4 +147,4 @@
 * @cathyjf made their first contribution in https://github.com/LizardByte/Sunshine/pull/2786
 * @cfalas made their first contribution in https://github.com/LizardByte/Sunshine/pull/2841
 
-**Full Changelog**: https://github.com/LizardByte/Sunshine/compare/v0.23.1...2024.713.195308
+**Full Changelog**: https://github.com/LizardByte/Sunshine/compare/v0.23.1...v2024.713.195308