Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lf 4380 api route for edit update route for edit animal and batch details #3484

Draft
wants to merge 20 commits into
base: integration
Choose a base branch
from
Draft

Lf 4380 api route for edit update route for edit animal and batch details #3484

wants to merge 20 commits into from

Commits on Sep 27, 2024

  1. LF-4380 Add edit route on animals and batches

    @Duncan-Brain
    Duncan-Brain committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    02567b0 View commit details
    Browse the repository at this point in the history

  2. LF-4380 Make edit endpoints for controller 

    Essentially seems to be working. Groups needs to be provided in obect format not array of ids.

TODO check identifier what happens on edit.
    @Duncan-Brain
    Duncan-Brain committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    f0907a2 View commit details
    Browse the repository at this point in the history

  3. LF-4380 Allow specifiying enum key for tests

    @Duncan-Brain
    Duncan-Brain committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    909ec4b View commit details
    Browse the repository at this point in the history

  4. LF-4380 Add use relationships to tableCleanup

    @Duncan-Brain
    Duncan-Brain committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    d7ec5c0 View commit details
    Browse the repository at this point in the history

  5. LF-4380 Add edit test and use async await on requests

    @Duncan-Brain
    Duncan-Brain committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    a9005fd View commit details
    Browse the repository at this point in the history

  6. LF-4380 Add tests for animal batches and add async await syntax to re… 

    …quests

To do:
- fix orgiin_id being editable
- sex detail has no constraints on multiple batch_id sex_id combination
- handle new types and breeds on animals and batches
- handle verifying count when sex details change and vice versa
    @Duncan-Brain
    Duncan-Brain committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6ecee80 View commit details
    Browse the repository at this point in the history

  7. LF-4380 Allow origin_id to be edited

    @Duncan-Brain
    Duncan-Brain committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    6b879c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. LF-4380 Add comment for delineating Remove tests

    @Duncan-Brain
    Duncan-Brain committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    12fd4b1 View commit details
    Browse the repository at this point in the history

  2. LF-4380 Move add animal functions to be reused in edit to utility fun… 

    …ction
    @Duncan-Brain
    Duncan-Brain committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    41e2a67 View commit details
    Browse the repository at this point in the history

  3. LF-4380 Replace code with utility function to be reused in edit, and … 

    …change plain insert with insertGraph
    @Duncan-Brain
    Duncan-Brain committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    8581fee View commit details
    Browse the repository at this point in the history

  4. LF-4380 Add utility functions to add batch and comments about groups too

    @Duncan-Brain
    Duncan-Brain committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    f994fa6 View commit details
    Browse the repository at this point in the history

  5. LF-4380 Update animals and batch edit endpoint to use types breeds an… 

    …d groups utilities
    @Duncan-Brain
    Duncan-Brain committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4338df8 View commit details
    Browse the repository at this point in the history

  6. LF-4380 Consolidate middleware for reuse in edit endpoint

    @Duncan-Brain
    Duncan-Brain committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    304d1ee View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. LF-4380 Extract logical checks for reuse

    @Duncan-Brain
    Duncan-Brain committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3e4543b View commit details
    Browse the repository at this point in the history

  2. LF-4380 WIP - Add type and breed checks to edit and refine functions 

    - change utility functions to use positive language versus negating the language
- commetns will be removed at the end
    @Duncan-Brain
    Duncan-Brain committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2d398ee View commit details
    Browse the repository at this point in the history

  3. LF-4380 Genericize type function

    @Duncan-Brain
    Duncan-Brain committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7e2dfa8 View commit details
    Browse the repository at this point in the history

  4. LF-4380 Reword check breed matched type to account for editing

    @Duncan-Brain
    Duncan-Brain committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    9690443 View commit details
    Browse the repository at this point in the history

  5. LF-4380 Finish consolidating breed checks to mirror type checks

    @Duncan-Brain
    Duncan-Brain committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    3eb111a View commit details
    Browse the repository at this point in the history

  6. LF-4380 Pass animalOrBatchRecord as prop, rename function, add comments

    @Duncan-Brain
    Duncan-Brain committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    dddfdc2 View commit details
    Browse the repository at this point in the history

  7. LF-4380 Add sex detail check to edit and adapt logical check for exis… 

    …ting record
    @Duncan-Brain
    Duncan-Brain committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    a4310da View commit details
    Browse the repository at this point in the history