-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lf 4380 api route for edit update route for edit animal and batch details #3484
Draft
Duncan-Brain
wants to merge
20
commits into
integration
Choose a base branch
from
LF-4380-api-route-for-edit-update-route-for-edit-animal-and-batch-details
base: integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Lf 4380 api route for edit update route for edit animal and batch details #3484
Duncan-Brain
wants to merge
20
commits into
integration
from
LF-4380-api-route-for-edit-update-route-for-edit-animal-and-batch-details
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Essentially seems to be working. Groups needs to be provided in obect format not array of ids. TODO check identifier what happens on edit.
…quests To do: - fix orgiin_id being editable - sex detail has no constraints on multiple batch_id sex_id combination - handle new types and breeds on animals and batches - handle verifying count when sex details change and vice versa
…change plain insert with insertGraph
…d groups utilities
- change utility functions to use positive language versus negating the language - commetns will be removed at the end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SUGGESTION: Follow the commits, most of code changes are copied test templates
Notes:
TODO:
Jira link: LF-4380
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: