Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG-FIX] Conditional visibility of sections for users #173

Merged
merged 6 commits into from
Aug 21, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 21, 2021

Lissy93 /FIX/section-visibility → Lissy93/dashy Commits: 6 | Files Changed: 7 | Additions: 103 Powered by Pull Request Badge

Category: Bugfix

Overview
#171 introduced granular user access, enabling certain sections to be hidden or shown to certain users. There was a mistake in the implementation, where the checking process was done on the Home view, and not in the main config accumulator, meaning that only sections within the Home view were correctly filtered. This PR fixes this, by moving the filtering functionality to a higher order.

  • f7ad520 - 🐛 Moves section filtering to higher order
  • c830418 - 🚚 Rename ItemGroup → Section

Issue Number #172

New Vars N/A

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 21, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: 007a13d

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/612128c146406b0007907c56

😎 Browse the preview: https://deploy-preview-173--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Aug 21, 2021

Changes preview:

👀 Review pull request on Viezly

@Lissy93 Lissy93 merged commit 053c55c into master Aug 21, 2021
@Lissy93 Lissy93 deleted the FIX/section-visibility branch August 21, 2021 17:05
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#173

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant