Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Granular User Access #171

Merged
merged 8 commits into from
Aug 20, 2021
Merged

[FEATURE] Granular User Access #171

merged 8 commits into from
Aug 20, 2021

Conversation

Lissy93
Copy link
Owner

@Lissy93 Lissy93 commented Aug 20, 2021

Lissy93 /FEATURE/granular-access-165 → Lissy93/dashy Commits: 8 | Files Changed: 12 | Additions: 144 Powered by Pull Request Badge

Category: Feature

Overview
Enables user to control which sections are visible to which users, including hiding sections for unauthenticated guest users

Issue Number #165

New Vars
The following new attributes are listed under sections.item[n].displayData

  • hideForUsers - Section will be visible to all users, except for those specified in this list
  • showForUsers - Section will be hidden from all users, except for those specified in this list
  • hideForGuests - Section will be visible for logged in users, but not for guests

Screenshot N/A

Code Quality Checklist (Please complete)

  • All changes are backwards compatible
  • All lint checks and tests are passing
  • There are no (new) build warnings or errors
  • (If a new config option is added) Attribute is outlined in the schema and documented
  • (If a new dependency is added) Package is essential, and has been checked out for security or performance
  • Bumps version, if new feature added

@netlify
Copy link

netlify bot commented Aug 20, 2021

✔️ Deploy Preview for dashy-dev ready!

🔨 Explore the source changes: d0c7fef

🔍 Inspect the deploy log: https://app.netlify.com/sites/dashy-dev/deploys/61201db7b07aab000718a508

😎 Browse the preview: https://deploy-preview-171--dashy-dev.netlify.app/

@viezly
Copy link

viezly bot commented Aug 20, 2021

Changes preview:

👀 Review pull request on Viezly

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2021

This pull request introduces 1 alert when merging 8df8425 into a8cf946 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@Lissy93 Lissy93 merged commit fa56446 into master Aug 20, 2021
@Lissy93 Lissy93 deleted the FEATURE/granular-access-165 branch August 20, 2021 21:33
asterling8516 pushed a commit to asterling8516/dashy that referenced this pull request Nov 23, 2023
Closes Lissy93#171

Signed-off-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant