Code splitting by route - Closes #519 #678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Initial load page size reduced from 4.4 MB [0] to 3.4 MB [1], that's a good chunk of data 👍 . Just some unit tests need to be updated. [0] https://tools.pingdom.com/#!/c1Tls4/https://jenkins.lisk.io/test/lisk-hub/development/ |
alepop
force-pushed
the
519-code-splitting-by-route
branch
from
d6cc5f5 to
f06cbc1
Compare
alepop
force-pushed
the
519-code-splitting-by-route
branch
2 times, most recently
from
c449a33 to
835dcfa
Compare
|
@slaweet rebased |
alepop
force-pushed
the
519-code-splitting-by-route
branch
from
835dcfa to
41cccb0
Compare
|
@slaweet is this still relevant if Lisk Hub now will be only shipped as a desktop app? |
|
@alepop IMO it's not relevant anymore. I'll close it now. We can always reopen the pr if the situation changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We have a big Lisk Hub js bundle that load all components for different routes
How did I fix it?
Created
asyncComponentthat allows import component only then it needed.How to test it?
Before code splitting:
After:
Review checklist