Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code-splitting by routes #519

Closed
alepop opened this issue Mar 5, 2018 · 2 comments
Closed

Code-splitting by routes #519

alepop opened this issue Mar 5, 2018 · 2 comments

Comments

@alepop
Copy link
Contributor

alepop commented Mar 5, 2018

Expected behaviour

Modify webpack config and react routing code to allow split finish bundle into the chanks by routes. Webpack will generate separate bundles for each of the route. And app will lazy loading needed modules by visited route. Example: If we visit transactions tab we don't need to load explorer relative modules and etc.

This will improve load performance, especially for mobile devices.
This issue relative to #509

Actual behaviour

Lisk Hub shipped to a user as a single code bundle.

Steps to reproduce

Visit Lisk Hub.

@slaweet
Copy link
Contributor

slaweet commented Mar 6, 2018

I agree this is something we should do at some point, but the benefit won't be huge.

The bundles should be heavily cached (after #514), so code-splitting causes speed up only on the first load.

The biggest part is the cryptography libs (js-nacl, bitcore-mnemonic) and those are needed on login page and authenticating the user to any page that requires logged user.

@slaweet
Copy link
Contributor

slaweet commented May 25, 2018

Not relevant since removing the hosted version. We can re-open in the future if things change.

@slaweet slaweet closed this as completed May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants