Automate Linux desktop build in Jenkins - Closes #609 #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reyraa
previously approved these changes
Mar 28, 2018
reyraa
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Linux build had to be built manually. (It's actually also the case for Win and Mac, but those will be handled some other time because they need to be signed which is more complicated)
How did I fix it?
Added
npm run distto Jenkins build on branches. I also removed build targets that we don't use to speed the build up.How to test it?
See the result of the branch build
https://jenkins.lisk.io/job/lisk-hub/job/609-linux-build-in-jenkins/
Review checklist