Implement 2nd passphrase registration - Closes #68 #554
Conversation
| <h5>{t('Security')}</h5> | ||
| <p>{t('Register 2nd passphrase')}</p> | ||
| </article> | ||
| </div> |
There was a problem hiding this comment.
The settings item should not be commented out until the 2nd passphrase registration is covered with tests (in #564)
| backButtonLabel={t('Back')}> | ||
| <CreateSecond title='Create' t={t} icon='add' /> | ||
| <Safekeeping title='Safekeeping' t={t} icon='checkmark' /> | ||
| <Confirm title='Confirm' t={t} confirmButton='Register' |
There was a problem hiding this comment.
Should be title={t('Create')} title={t('Safekeeping')} title={t('Confirm')}
| onClick={() => nextStep({ | ||
| passphrase: this.state.passphrase, | ||
| header: t('Your passphrase is used to access your Lisk ID.'), | ||
| message: t('I am responsible for keeping my passphrase safe. No one can reset it, not even Lisk.'), |
There was a problem hiding this comment.
header and message should IMO be defined in
https://github.com/LiskHQ/lisk-hub/blob/fbc7d66dc9cae07b2381d3c0f10ce4b433a4edd9/src/components/register/register.js#L54
| }); | ||
| }, 300); | ||
| } | ||
| } |
There was a problem hiding this comment.
Most of this logic is duplicated from
https://github.com/LiskHQ/lisk-hub/blob/fbc7d66dc9cae07b2381d3c0f10ce4b433a4edd9/src/components/passphrase/create/index.js
There should be a common component for the logic of 1st and 2nd passphrase generation, only the presentation part should be different for 1st and 2nd passphrase generation. This might be worth a separate task.
There was a problem hiding this comment.
I have created issue #577 to fix this problem
What was the problem?
2nd passphrase registration component didn't Implement
this PR also covers #568 and #569
there is #564 issue for improving test coverage
Review checklist