Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate logic from presentation in 1st and 2nd passphrase generation #577

Closed
yasharAyari opened this issue Mar 20, 2018 · 0 comments
Closed

Separate logic from presentation in 1st and 2nd passphrase generation #577

yasharAyari opened this issue Mar 20, 2018 · 0 comments
Assignees
@ginacontrino
Labels
type: refactoring

Comments

@yasharAyari
Copy link
Contributor

Expected behaviour

There should be a common component for the logic of 1st and 2nd passphrase generation, only the presentation part should be different for 1st and 2nd passphrase generation.

Actual behaviour

There are some common logic in 1st and 2nd passphrase generation and those have been implemented twice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ginacontrino ginacontrino

Labels
type: refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@slaweet @yasharAyari @ginacontrino